-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update interface of IsValidCommittedSeal and InsertBlock by go-ibft's update #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Make sure to update this branch as soon as we merge out the PR on go-ibft
🙏
Make sure to also add the |
Codecov Report
@@ Coverage Diff @@
## develop #677 +/- ##
===========================================
+ Coverage 48.65% 48.71% +0.05%
===========================================
Files 112 112
Lines 15364 15372 +8
===========================================
+ Hits 7476 7488 +12
+ Misses 7254 7252 -2
+ Partials 634 632 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Description
Fix the method interfaces of IBFTBackend (IsValidCommittedSeal, InsertBlock) based on go-ibft's update (0xPolygon/go-ibft#24)
Please run
go mod vendor
after 0xPolygon/go-ibft#24 is merged before this PR is mergedChanges include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it